Skip to content

fix anonymous access for DjangoModelPermissionsOrAnonReadOnly #9315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix anonymous access for DjangoModelPermissionsOrAnonReadOnly #9315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4cb27f
fix anonymous access for DjangoModelPermissionsOrAnonReadOnly
farnswj1 Mar 20, 2024
25d4a40
Add tests for DjangoModelPermissionsOrAnonReadOnly
farnswj1 Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions rest_framework/permissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,12 @@ class DjangoModelPermissionsOrAnonReadOnly(DjangoModelPermissions):
"""
authenticated_users_only = False

def has_permission(self, request, view):
if request.user and request.user.is_authenticated:
return bool(super().has_permission(request, view))

return bool(request.method in SAFE_METHODS)


class DjangoObjectPermissions(DjangoModelPermissions):
"""
Expand Down
38 changes: 38 additions & 0 deletions tests/test_permissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ class RootView(generics.ListCreateAPIView):
permission_classes = [permissions.DjangoModelPermissions]


class AnonReadOnlyRootView(RootView):
permission_classes = [permissions.DjangoModelPermissionsOrAnonReadOnly]


class InstanceView(generics.RetrieveUpdateDestroyAPIView):
queryset = BasicModel.objects.all()
serializer_class = BasicSerializer
Expand Down Expand Up @@ -65,6 +69,7 @@ class IgnoredGetQuerySetListView(GetQuerySetListView):
get_queryset_list_view = GetQuerySetListView.as_view()
empty_list_view = EmptyListView.as_view()
ignored_get_queryset_list_view = IgnoredGetQuerySetListView.as_view()
anon_read_only_root_view = AnonReadOnlyRootView.as_view()


def basic_auth_header(username, password):
Expand Down Expand Up @@ -285,6 +290,39 @@ def get_queryset(self):
with self.assertRaisesMessage(AssertionError, 'View.get_queryset() returned None'):
view(request)

def test_allow_anonymous_safe_access_to_anon_read_only_view(self):
request = factory.get('/', HTTP_AUTHORIZATION='')
response = anon_read_only_root_view(request)
self.assertEqual(response.status_code, status.HTTP_200_OK)

def test_deny_anonymous_unsafe_access_to_anon_read_only_view(self):
request = factory.post('/', {'text': 'foobar'}, format='json',
HTTP_AUTHORIZATION='')
response = anon_read_only_root_view(request)
self.assertEqual(response.status_code, status.HTTP_401_UNAUTHORIZED)

def test_allow_permitted_safe_access_to_anon_read_only_view(self):
request = factory.get('/', HTTP_AUTHORIZATION=self.permitted_credentials)
response = anon_read_only_root_view(request)
self.assertEqual(response.status_code, status.HTTP_200_OK)

def test_allow_permitted_unsafe_access_to_anon_read_only_view(self):
request = factory.post('/', {'text': 'foobar'}, format='json',
HTTP_AUTHORIZATION=self.permitted_credentials)
response = anon_read_only_root_view(request)
self.assertEqual(response.status_code, status.HTTP_201_CREATED)

def test_deny_disallowed_safe_access_to_anon_read_only_view(self):
request = factory.post('/', HTTP_AUTHORIZATION=self.disallowed_credentials)
response = anon_read_only_root_view(request)
self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)

def test_deny_disallowed_unsafe_to_anon_read_only_view(self):
request = factory.post('/', {'text': 'foobar'}, format='json',
HTTP_AUTHORIZATION=self.disallowed_credentials)
response = anon_read_only_root_view(request)
self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)


class BasicPermModel(models.Model):
text = models.CharField(max_length=100)
Expand Down