Skip to content

Fixed a couple of small problems I found when using the action decorator. #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2013
Merged

Fixed a couple of small problems I found when using the action decorator. #941

merged 2 commits into from
Jun 21, 2013

Conversation

philipdouglas
Copy link
Contributor

No description provided.

@philipdouglas
Correct docs' incorrect usage of action decorator
f3529f1 
If you don't call it, it doesn't work.
@philipdouglas
Allow uppercase methods in action decorator.
fa9f5fb 
Previously, using uppercase for the method argument would silently fail
to route those methods.
lovelydinosaur added a commit that referenced this pull request Jun 21, 2013
@lovelydinosaur
Merge pull request #941 from FreakyDug/master
8b0d411 
Fixed a couple of small problems I found when using the action decorator.
@lovelydinosaur lovelydinosaur merged commit 8b0d411 into encode:master Jun 21, 2013
@lovelydinosaur
Copy link
Collaborator

I've dropped the @action() change you made to the docs - that's not required. Without arguments @action will work just fine. The whitespacing and the HTTP method name case-insensitivity changes are good tho. 👍

lovelydinosaur added a commit that referenced this pull request Jun 21, 2013
@lovelydinosaur
Added @freakydug, for changes in #941. Thanks :)
4f7f93e
@mindlace-mp
Copy link
Contributor

Really? It didn't work for me without the ().

On Fri, Jun 21, 2013 at 2:27 PM, Tom Christie notifications@github.comwrote:

I've dropped the @action() change you made to the docs - that's not
required. Without arguments @action will work just fine. The whitespacing
and the HTTP method name case-insensitivity changes are good tho. [image:
👍]

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/941#issuecomment-19841780
.

lovelydinosaur added a commit that referenced this pull request Jun 21, 2013
@lovelydinosaur
Add decorator brackets back. Refs #941
8d83ff8
@lovelydinosaur
Copy link
Collaborator

Apologies - you're absolutely right.
It would be nice if they weren't required, but my decorator creating magicks are not up to much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipdouglas @lovelydinosaur @mindlace-mp