Text validation #160
Merged
Text validation #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For float, int, and Vector2 types. If the text is not valid, reset to the last submitted text and don't emit the midified signal.
We are not exposing PI or TAU constants. It's simpler to have a single way to set/change rotation as degrees. The Godot UI also has a degrees slider for Node2D rotation. rotation_degrees is a property, so remove the custom setter.
All possible blocks gain default values. So they can be used directly without having to type a value. And most importantly, so the script is not generated with syntax errors. The defaults are opinionated, they have to be. Eg. set scale to double size, change position so the node2d moves to the right-bottom. Also: remove "change by" block for modulate and visible properties. They don't make sense. https://phabricator.endlessm.com/T35562
|
The tests encountered a bug. This is now ready for review again. |
dylanmccall
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation for the input text, and default values for blocks. Goal is to prevent generated code with syntax errors. It also improves the UX.
https://phabricator.endlessm.com/T35562