T35591 Read block definition from resource files #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are more blocks that can be ported. I'm finding missing ones like "Await scene ready". I'm making sure we don't miss anything in the port. The if/else can't be ported as-is unless we split them into 2 blocks. |
dylanmccall
approved these changes
Aug 13, 2024
| @@ -5,14 +5,14 @@ extends Resource | |||
| const Types = preload("res://addons/block_code/types/types.gd") | |||
|
|
|||
| @export var name: StringName | |||
| @export var description: String | |||
| @export_multiline var description: String | |||
There was a problem hiding this comment.
Oh, nice! This was bugging me :)
There was a problem hiding this comment.
A tiny nit: can we sort this commit right before a5c9b4b, or even squash the two? I was left asking "but why?!" and it took a while to find the answer.
There was a problem hiding this comment.
Good point, otherwise is not understandable why the utility was added.
This way the editor shows a text box for editing these fields allowing multiple lines. Previously the newlines appeared encoded as `\\n`.
So they can be instantiated for now from block definitions. Note that this won't work for control blocks with multiple bodies like if/else.
Given a directory path, the function will return all files whose file name matches the given pattern. Co-authored-by: Will Baumgartner <wnb@endlessos.org>
To the current ones. Done using the editor Inspector dock.
And remove the 2 definitions from code. Please note the name of the On Ready block has changed. This will be addressed in the next commit.
This is how it's now named in the resource files.
To the new block definitions. Update the resource files to match the current values when needed.
d4e69f2 to
3971f47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking as reference commits from #147
Notable changes:
https://phabricator.endlessm.com/T35591