Skip to content

Check _selected_block_code is still valid before disconnecting #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

dylanmccall
Copy link
Contributor

Previously, it was possible for _selected_block_code to refer to an object which had been freed, which resulted in an error when calling disconnect for its signals.

Previously, it was possible for _selected_block_code to refer to an
object which had been freed, which resulted in an error when calling
disconnect for its signals.
Copy link
Contributor

@starnight starnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@starnight starnight merged commit f5ff37c into main Aug 30, 2024
3 checks passed
@starnight starnight deleted the fix-disconnect-freed-object branch August 30, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants