Skip to content

Add SimpleSpawner node and blocks #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Add SimpleSpawner node and blocks #230

merged 2 commits into from
Sep 25, 2024

Conversation

manuq
Copy link
Contributor

@manuq manuq commented Sep 25, 2024

This is a node with blocks to simplify the instantiation of other scenes and adding them to the current one.

Instantiated scenes are added as children of the SimpleSpawner node, so their position, ordering, etc, is relative to this node.

Blocks are provided to spawn once and to start / stop spawning based on a frequency.

Multiple scenes can be provided to be instantiated. In which case one is randomly picked when spawning.

For performance concerns, the amount of instantiated scenes is limited by default, unless the learner sets the limit to be zero (unlimited).

There are 2 behaviors to choose for when the limit is reached:

  • Replace: Remove the oldest spawned scene and spawn a new one.
  • No Spawn: No spawn happens until any spawned scene is removed by other means.

https://phabricator.endlessm.com/T35662

This is a node with blocks to simplify the instantiation of other scenes
and adding them to the current one.

Instantiated scenes are added as children of the SimpleSpawner node, so
their position, ordering, etc, is relative to this node.

Blocks are provided to spawn once and to start / stop spawning based on
a frequency.

Multiple scenes can be provided to be instantiated. In which case one is
randomly picked when spawning.

For performance concerns, the amount of instantiated scenes is limited
by default, unless the learner sets the limit to be zero (unlimited).

There are 2 behaviors to choose for when the limit is reached:
- Replace: Remove the oldest spawned scene and spawn a new one.
- No Spawn: No spawn happens until any spawned scene is removed by other
means.

https://phabricator.endlessm.com/T35662
Copy link
Contributor

@starnight starnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@starnight starnight merged commit 73d7d00 into main Sep 25, 2024
3 checks passed
@starnight starnight deleted the T35662-simple-spawner branch September 25, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants