Skip to content

blocks: Use string type for group names #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

dylanmccall
Copy link
Contributor

This spares us some grief in the code templates for different group-related blocks.

https://phabricator.endlessm.com/T35647

Copy link
Member

@dbnicholson dbnicholson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I thought the type always had to be NIL when using options.

@dbnicholson dbnicholson merged commit c00ec59 into main Oct 3, 2024
3 checks passed
@dbnicholson dbnicholson deleted the fix-group-code-generation branch October 3, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants