Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add deprecation on indent, quotes and semi rule types #19090

Merged

Conversation

marcalexiei
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Add deprecation notice on some stylistic issues deprecated rules

What changes did you make? (Give an overview)

On lib/types/rules/stylistic-issues.d.ts there are some deprecated rules
that do not have @deprecated marker, even if on documentation they are marked as so:

Is there anything you'd like reviewers to focus on?

No

@marcalexiei marcalexiei requested a review from a team as a code owner November 2, 2024 14:12
@eslint-github-bot
Copy link

Hi @marcalexiei!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

Copy link

netlify bot commented Nov 2, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 728fdf3
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67263608f30e330008389ada

@marcalexiei marcalexiei changed the title fix: add deprecation warning on indent,quotes and semi rules configuration types fix: add deprecation on indent,quotes and semi rules configuration types Nov 2, 2024
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Nov 2, 2024
@marcalexiei marcalexiei force-pushed the deprecated-missing-styles-rules branch from 8bd86b0 to 83d939d Compare November 2, 2024 14:15
@marcalexiei marcalexiei force-pushed the deprecated-missing-styles-rules branch from 83d939d to 728fdf3 Compare November 2, 2024 14:24
@Tanujkanti4441 Tanujkanti4441 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Nov 2, 2024
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Marking this as a docs change.

@snitin315 snitin315 changed the title fix: add deprecation on indent,quotes and semi rules configuration types docs: add deprecation on indent,quotes and semi rules configuration types Nov 2, 2024
@eslint-github-bot
Copy link

Hi @marcalexiei!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@snitin315 snitin315 added the documentation Relates to ESLint's documentation label Nov 2, 2024
@snitin315 snitin315 changed the title docs: add deprecation on indent,quotes and semi rules configuration types docs: add deprecation on indent, quotes and semi rule types Nov 2, 2024
@mdjermanovic mdjermanovic added the types Related to TypeScript types label Nov 2, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just waiting for #19038 before merging.

@mdjermanovic mdjermanovic merged commit 522d8a3 into eslint:main Nov 4, 2024
26 checks passed
@marcalexiei marcalexiei deleted the deprecated-missing-styles-rules branch November 5, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly documentation Relates to ESLint's documentation types Related to TypeScript types
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

5 participants