This repository was archived by the owner on Jan 19, 2019. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 75
[indent] import require are not reported as error #577
Labels
Comments
|
bradzacher
added a commit
to bradzacher/eslint-plugin-typescript
that referenced
this issue
Dec 17, 2018
Fixes #201 Fixes #96 Fixes eslint/typescript-eslint-parser#577 The [base eslint implementation](https://github.com/eslint/eslint/blob/master/lib/rules/indent.js) purposely ignores nodes it doesn't know about (i.e. our TS nodes). Because of how the base rule is written, we have to override the implementation entirely.
It should be fixed by bradzacher/eslint-plugin-typescript#219 |
JamesHenry
pushed a commit
to typescript-eslint/typescript-eslint
that referenced
this issue
Jan 17, 2019
Fixes #201 Fixes #96 Fixes eslint/typescript-eslint-parser#577 The [base eslint implementation](https://github.com/eslint/eslint/blob/master/lib/rules/indent.js) purposely ignores nodes it doesn't know about (i.e. our TS nodes). Because of how the base rule is written, we have to override the implementation entirely.
JamesHenry
pushed a commit
to typescript-eslint/typescript-eslint
that referenced
this issue
Jan 17, 2019
Fixes #201 Fixes #96 Fixes eslint/typescript-eslint-parser#577 The [base eslint implementation](https://github.com/eslint/eslint/blob/master/lib/rules/indent.js) purposely ignores nodes it doesn't know about (i.e. our TS nodes). Because of how the base rule is written, we have to override the implementation entirely.
JamesHenry
pushed a commit
to typescript-eslint/typescript-eslint
that referenced
this issue
Jan 18, 2019
Fixes #201 Fixes #96 Fixes eslint/typescript-eslint-parser#577 The [base eslint implementation](https://github.com/eslint/eslint/blob/master/lib/rules/indent.js) purposely ignores nodes it doesn't know about (i.e. our TS nodes). Because of how the base rule is written, we have to override the implementation entirely.
nightsky108
pushed a commit
to nightsky108/typescript-eslint
that referenced
this issue
Dec 21, 2021
Fixes #201 Fixes #96 Fixes eslint/typescript-eslint-parser#577 The [base eslint implementation](https://github.com/eslint/eslint/blob/master/lib/rules/indent.js) purposely ignores nodes it doesn't know about (i.e. our TS nodes). Because of how the base rule is written, we have to override the implementation entirely.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of TypeScript are you using?
3.1.6
What version of
typescript-eslint-parser
are you using?21.0.2
What code were you trying to parse?
What did you expect to happen?
An error because the code is indented but shouldn't.
For now my rule indent is:
What happened?
No error.
The text was updated successfully, but these errors were encountered: