Skip to content

ESP_PanelVersions.h line 98 - MINOR > PATCH? #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arduinomnomnom opened this issue Jan 9, 2025 · 1 comment
Closed

ESP_PanelVersions.h line 98 - MINOR > PATCH? #148

arduinomnomnom opened this issue Jan 9, 2025 · 1 comment

Comments

@arduinomnomnom
Copy link

Line 98 of ESP_PanelVersions.h contains

#elif ESP_PANEL_BOARD_CUSTOM_FILE_VERSION_MINOR > ESP_PANEL_BOARD_CUSTOM_VERSION_PATCH

I get a false compile warning "The file ESP_Panel_Board_Custom.h version is newer than the library".

Should VERSION_PATCH be VERSION_MINOR instead?
@Lzw655
Copy link
Collaborator

Lzw655 commented Jan 9, 2025

Hi @arduinomnomnom,

You are right! It's a mistake and I will fix it now. Thank you for pointing out this issue!

@Lzw655 Lzw655 mentioned this issue Jan 9, 2025
Merged
@Lzw655 Lzw655 closed this as completed in 603446d Jan 10, 2025
@Lzw655 Lzw655 mentioned this issue Feb 17, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arduinomnomnom @Lzw655