Skip to content

V1.0.0 Doesn't Compile... #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Shadowtrance opened this issue Feb 18, 2025 · 2 comments
Closed

V1.0.0 Doesn't Compile... #162

Shadowtrance opened this issue Feb 18, 2025 · 2 comments

Comments

@Shadowtrance
Copy link

V1.0.0 doesn't compile on esp-idf (5.4) or Arduino (3.1.1) if buttons are set to 0.
Buttons being set to 0 fail seems to be fixed by wrapping the below line and function with the max button check in esp_panel_touch.cpp

#if (CONFIG_ESP_LCD_TOUCH_MAX_BUTTONS > 0)

#endif

line 308
    ESP_UTILS_CHECK_FALSE_RETURN(readRawDataButtons(buttons_num), false, "Read buttons failed");

line 601
bool Touch::readRawDataButtons(int buttons_num)

But i still fails after that with.

espressif__esp32_display_panel/libespressif__esp32_display_panel.a(esp_panel_board.cpp.obj):(.literal._ZN9esp_panel7drivers6BusI2CC5ERKNS1_6ConfigE[_ZN9esp_panel7drivers6BusI2CC5ERKNS1_6ConfigE]+0x8): undefined reference to `vtable for esp_panel::drivers::BusI2C'
Lzw655 added a commit that referenced this issue Feb 19, 2025
@Lzw655
fix(touch): avoid reading the button state when disabled
2e486bd 
Closes #162
Lzw655 added a commit that referenced this issue Feb 19, 2025
@Lzw655
fix(touch): avoid reading the button state when disabled (#162)
efee7e2 
Closes #162
@Lzw655
Copy link
Collaborator

Lzw655 commented Feb 19, 2025

Hi @Shadowtrance,

Thank you for reporting this issue! It can be fixed by commit.

@Shadowtrance
Copy link
Author

Nice!
It builds properly now :)
The last part was my fault as i forgot to enable the i2c driver in menufonfig.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Shadowtrance @Lzw655