Skip to content

Adding Waveshare ESP32-S3 Touch LCD 2.8C #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Adding Waveshare ESP32-S3 Touch LCD 2.8C #225

wants to merge 2 commits into from

Conversation

martinroger
Copy link
Contributor

  • Adding support for Waveshare ESP32-S3 Touch LCD 2.8C (as in circular display)
  • Added information on how to use the esp_panel_board_custom_conf.h file easily with ESP-IDF
  • Bump ESP_PANEL_BOARD_SUPPORTED_FILE_VERSION to 1.2.0 proposed
  • Bump ESP_PANEL_VERSION to 1.0.4 proposed
  • Minor correction in one supported board definition file.

@martinroger
Copy link
Contributor Author

martinroger commented Jul 8, 2025 •
edited
Loading

FYI @Lzw655 I think there is something odd with the version check python script, pre-commit appears to fail on one specific file (both on Github Actions and on my valiant Raspberry Pi) after I moved the library version of `esp_panel_board_supported_conf`` from 1.1.0 to 1.2.0 :

File version extracted from 'examples/arduino/gui/lvgl_v8/simple_port/esp_panel_board_supported_conf.h': {'file': 'esp_panel_board_supported_conf.h', 'version': '1.1.0'}
Version mismatch: 'esp_panel_board_supported_conf.h'

Check library versions...................................................Passed
pre-commit hook(s) made changes.
If you are seeing this message in CI, reproduce locally with: `pre-commit run --all-files`.
To run `pre-commit` as part of git workflow, use `pre-commit install`.
All changes made by hooks:
diff --git a/examples/arduino/gui/lvgl_v8/simple_port/esp_panel_board_supported_conf.h b/examples/arduino/gui/lvgl_v8/simple_port/esp_panel_board_supported_conf.h
index b25171b..3378176 100644
--- a/examples/arduino/gui/lvgl_v8/simple_port/esp_panel_board_supported_conf.h
+++ b/examples/arduino/gui/lvgl_v8/simple_port/esp_panel_board_supported_conf.h
@@ -175,7 +175,7 @@
  * 3. Patch version mismatch: No impact on functionality
  */
 #define ESP_PANEL_BOARD_SUPPORTED_FILE_VERSION_MAJOR 1
-#define ESP_PANEL_BOARD_SUPPORTED_FILE_VERSION_MINOR 2
+#define ESP_PANEL_BOARD_SUPPORTED_FILE_VERSION_MINOR 1
 #define ESP_PANEL_BOARD_SUPPORTED_FILE_VERSION_PATCH 0

Somehow it is perfectly happy with the copies of that same file in all the other example folders.

I think I found the issue... third PR attempt incoming.

@martinroger martinroger closed this Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martinroger