Skip to content

Add resolution column in Board_Instructions.md #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add resolution column in Board_Instructions.md #51

wants to merge 3 commits into from

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Jun 16, 2024 •
edited
Loading

Add resolution column in Board_Instructions.md

@lboue lboue marked this pull request as draft June 16, 2024 07:59
lboue added 2 commits June 16, 2024 10:01
@lboue
Add resolution for Shenzhen Jingcai Intelligent in Update Board_Instr…
dd93006 
…uctions.md

Add resolution for Shenzhen Jingcai Intelligent
@lboue
Add resolution column for Espressif in Update Board_Instructions.md
dd0f3b9 
Add resolution column for Espressif
@lboue lboue changed the title Add resolution column in Update Board_Instructions.md Add resolution column in Board_Instructions.md Jun 16, 2024
@lboue lboue marked this pull request as ready for review June 16, 2024 08:27
@lboue
Copy link
Contributor Author

lboue commented Jun 16, 2024

I didn't find LCD resolution for this board: ESP32-S3-USB-OTG

@Lzw655 Lzw655 mentioned this pull request Jun 17, 2024
Merged
@Lzw655 Lzw655 closed this in 7631fb6 Jun 17, 2024
Lzw655 added a commit that referenced this pull request Jun 17, 2024
@Lzw655
Merge pull request #53 from esp-arduino-libs/bugfix/fix_conf_include_…
30f8360 
…inside_error

* feat(docs): add resolution column in board instructions by @lboue (#51)
* fix(conf): fix error when include inside file (#52)
* fix(docs): switch M5Stack doc links to english by @lboue (#50)
@Lzw655
Copy link
Collaborator

Lzw655 commented Jun 17, 2024

Hi @lboue, thank you for your contribution. It's thoughtful of you to add resolution information for all boards. I have added the resolution (240x240) of ESP32-S3-USB-OTG in the docs.

@lboue lboue deleted the resolution branch July 28, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lboue @Lzw655