feat(memory): add c++ global allocate functions #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces C++ global memory allocation support while refactoring and modularizing the existing memory allocation code. Key changes include:
- Removal of legacy C/C++ general allocation functions from esp_utils_mem.c.
- Addition of dedicated header files for standard, MicroPython, and ESP-specific memory allocation macros.
- Extended configuration and version updates (including global C++ allocation settings) and adjustments to workflow file checkouts.
Reviewed Changes
Copilot reviewed 27 out of 31 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/memory/esp_utils_mem.c | Removed legacy allocation functions, preserving minimal info printing. |
| src/memory/allocation/esp_utils_mem_std.h | Added stdlib allocation macros. |
| src/memory/allocation/esp_utils_mem_mpy.h | Added MicroPython allocation macros. |
| src/memory/allocation/esp_utils_mem_esp.h | Added ESP-specific allocation macros based on heap_caps. |
| src/log/esp_utils_log.h | Streamlined logging macros and external function declarations. |
| src/esp_utils_versions.h | Updated version definitions. |
| src/esp_utils_types.h | Introduced new memory caps macros. |
| src/esp_utils_conf_kconfig.h & esp_utils_conf.h | Updated configuration error handling and new global allocation configs. |
| .github/workflows/* | Updated checkout actions and tool versions. |
| CHANGELOG.md | Documented new C++ global memory allocation feature. |
Files not reviewed (4)
- CMakeLists.txt: Language not supported
- Kconfig: Language not supported
- library.properties: Language not supported
- micropython.cmake: Language not supported
Comments suppressed due to low confidence (1)
esp_utils_conf.h:79
- Consider replacing the hardcoded alignment value '1' with a configuration constant (e.g. ESP_UTILS_CONF_MEM_GEN_ALLOC_ESP_ALIGN) to ensure consistency with other allocation settings.
#define ESP_UTILS_CONF_MEM_GEN_ALLOC_CUSTOM_MALLOC(x) heap_caps_aligned_alloc(1, x, MALLOC_CAP_DEFAULT | MALLOC_CAP_8BIT)
0cb6443 to
fb86a82
Compare
fb86a82 to
55e90d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.