-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Pull (#6765) breaks arduino-esp8266fs-plugin functionality #6777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It's not correct, you ignored the issue template which requires certain information. Please edit your post above, add the template, follow the instructions in it, and fill out the required info. |
@earlephilhower I think a new plugin version is needed |
Looks like changing some lines in ESP8266FS.java of arduino-esp8266fs-plugin to directly invoke esptool.py is the best and easiest solution. For me it's working. I'll try to send my proposal there. |
I hope it's ok now. Thanks. |
It's enough, and much better than other cases. Thank you! I fixed the one thing missing: a reference in the description to the PR that broke the plugins. Strictly speaking you're correct to close this issue and raise the problem in the other repo(s). However, I consider this case to be a bit special:
All of this means that special coordination and tracking is needed, so I'm keeping this issue open. In addition, the README needs to be updated:
|
LittleFS plugin repo: https://github.com/earlephilhower/arduino-esp8266littlefs-plugin |
We can also ignore |
Then there is still: cmdline = cmdline + ['0x0', binary] ... that adds the '0x0'... Changing plugins to directly invoke esptool.py seems to me to be the easiest fix (of course it's a beginners opinion :) |
And now looking a second time at the code my problem description in the first post seems to be incomplete. cmdline in "esptool.main(cmdline)" becomes: ['--chip', 'esp8266', '--port', '/dev/ttyUSB0', '--baud', '460800', 'write_flash', '0x200000', '--end', 'write_flash', '0x0', '/tmp/arduino_build_949720/something.bin'] ...so 'write_flash' is passed two times too because of: cmdline = cmdline + ['write_flash']. |
Changing: to File uploadPyFile = new File(platform.getFolder()+"/tools/esptool", "esptool.py"); and sysExec(new String[]{pythonCmd, uploadCmd, "--chip", "esp8266", "--port", serialPort, "--baud", uploadSpeed, "write_flash", uploadAddress, imagePath, "--end"}); to sysExec(new String[]{pythonCmd, uploadCmd, "--chip", "esp8266", "--port", serialPort, "--baud", "460800", "write_flash", uploadAddress, imagePath}); in ESP8266FS.java of the arduino-esp8266fs-plugin was the way to fix it for me. It needs further investigation if it works for every OS and every condition. Two lines of code :) |
It is now time to make your pull-requests on these repositories ! |
May a fix for: esp8266/Arduino#6777
Closing as fixed w/#6788 |
Basic Infos
Platform
Settings in IDE
Problem Description
Hi,
First time as active github contributor here so please forgive if not everything is correct.
The change in upload.py breaks arduino-esp8266fs-plugin functoinality.
The plugin esp8266fs.jar executes:
....upload.py --chip esp8266 --port /dev/ttyUSB0 --baud 921600 write_flash 0x200000/tmp/something.bin --end
... so that esptool gives out:
esptool write_flash: error: argument
: Must be pairs of an address and the binary filename to write thereThe problem seems to be that the change in upload.py.
cmdline in "esptool.main(cmdline)" becomes:
--chip', 'esp8266', '--port', '/dev/ttyUSB0', '--baud', '460800', 'write_flash', '0x200000', '--end', '0x0', '/tmp/something.bin'
... so that '--end' is passed to esptool and '0x0' is passed aditionally but should not.
Ref: #6765
The text was updated successfully, but these errors were encountered: