Skip to content

Return type ESP8266WiFiGenericClass::channel() #7643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Erriez opened this issue Oct 7, 2020 · 0 comments · Fixed by #7656
Closed

Return type ESP8266WiFiGenericClass::channel() #7643

Erriez opened this issue Oct 7, 2020 · 0 comments · Fixed by #7656

Comments

@Erriez
Copy link
Contributor

Erriez commented Oct 7, 2020

The datasheet page 89 describes prototype:

uint8 wifi_get_channel(void)

The source code returns int32_t:

Arduino/libraries/ESP8266WiFi/src/ESP8266WiFiGeneric.cpp

Line 257 in bc2b13a

int32_t ESP8266WiFiGenericClass::channel(void) {

Proposal to change prototype to:

uint8_t ESP8266WiFiGenericClass::channel(void);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING: Change return type of channel() esp8266/Arduino
1 participant
@Erriez