WebServer: handle initial read/close timeouts asynchronously #1401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is a delay before data becomes available on a new connection then the handler function blocks for up to 1 second, and there's another wait on connection close for up to 2 seconds. This doesn't make the whole server process asynchronous (there is another delay between headers/data) but it helps when there are other events that need attention while handling web requests.
|
I've done a few tests and this seems to work fine. However I would ask more people to test this change and report feedback here, as there might be some potential edge cases depending on client behaviour. |
|
I tested it and can confirm that the web server runs stable for me. |
|
Can't say if its faster but no (additional) problems observed. |
igrr
added a commit
that referenced
this pull request
Jan 18, 2016
WebServer: handle initial read/close timeouts asynchronously
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a delay before data becomes available on a new connection
then the handler function blocks for up to 1 second, and there's another
wait on connection close for up to 2 seconds.
This doesn't make the whole server process asynchronous (there is another
delay between headers/data) but it helps when there are other events
that need attention while handling web requests.