Update CaptivePortal.ino #6173
Closed
Update CaptivePortal.ino #6173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why don't you use official private network address range instead of 172.217.28/24 which is public (belonging to google at the moment) ? |
|
because android only automatically opens the captive portal promt if the google adress it is checking to see if internet connection is availabel is not direkted to a private ip adress. i did not discover this but i confiremd it with all devices available to me. i found this problem here: |
|
@MisterD66 thanks for the useful link. |
|
closed by #5529 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android devices have a feature that opens a captive portal right after connecting to an accesspoint. to trigger this feature the target IP Adress cant be in the 192.168.x.x range.
After testing this on three devices and all of them work with the new ip adress and not the old i propose to change it
Tested on:
Xiamoi Redmi Note 4 (Android 7)
Samsung Galaxy A7 (Android 8)
Amazon Fire 7 (Android 5)