Add missing "LittleFS.begin()" in LittleFS_Timestamp example. #6762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing first LittleFS.begin() call.
devyte
requested changes
Nov 13, 2019
There was a problem hiding this comment.
This doesn't look right to me.
- My understanding is that the FS must be unmounted before formatting. This forces mounting before formatting. I think LittleFS.end() would need to be called before LittleFS.format()
- If the FS is not created, e.g.: wipe the entire flash, download the sketch, and then boot, then formatting is supposed to create it. In that case, this change will try to mount the FS, fail, and quit, disallowing formatting.
- I think an attempt should be done to mount. If it fails, it should be formatted. Then, the dir and file operations should be done.
earlephilhower
requested changes
Nov 14, 2019
earlephilhower
approved these changes
Nov 14, 2019
devyte
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing first LittleFS.begin() call.