Mark esp_schedule IRAM_ATTR to make it ISR safe #6809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e suspend CONT via esp_yield pattern in esp_delay for early returning from delay due to external events. In libraries/ESP8266WiFi/src/ESP8266WiFiGeneric.cpp this is done from CBs, that are called from tools/sdk/lwip/include/lwip/dns.h
0d15259 to
6cdc843
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caveat: This may be due to my ignorance of ESP8266 SYS/CONT scheduling internals.
Otherwise, though:
This complements the suspend CONT via
esp_yield()pattern inesp_delay()for early returning from the delay due to external events. Inlibraries/ESP8266WiFi/src/ESP8266WiFiGeneric.cppthis is also done from CBs, that are called fromtools/sdk/lwip/include/lwip/dns.h, for instance.