Skip to content

Pull GPIO initialization into its own 'weak' function. #7044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2020
Merged

Pull GPIO initialization into its own 'weak' function. #7044

merged 3 commits into from
Mar 22, 2020

Conversation

everslick
Copy link
Contributor

By pulling GPIO init into its own weak function, it can be overridden by the user. This is important in cases when GPIOs should not toggle during reboot, exceptions or other crashes. Fixes #7041.

@everslick
Pull GPIO initialization into its own 'weak' function.
ede7e8e 
By pulling GPIO init into its own weak function, it can be overridden by the user. This is important in cases when GPIOs should not toggle during reboot, exceptions or other crashes. Fixes #7041.
@everslick everslick mentioned this pull request Jan 29, 2020
Closed
@d-a-v d-a-v added this to the 2.7.0 milestone Mar 17, 2020
@d-a-v
Copy link
Collaborator

d-a-v commented Mar 18, 2020

@everslick
Will you fix this error ?

core_esp8266_wiring_digital.cpp: In function 'void initPins()':
core_esp8266_wiring_digital.cpp:254:13: error: 'resetPins' was not declared in this scope
   resetPins();
             ^

@everslick
Copy link
Contributor Author

everslick commented Mar 19, 2020 •
edited
Loading

I think it is only the missing prototype void resetPins(); in wiring_private.h. I submitted the PR via the github online editor. , which only allows me to change ONE file per PR (I think).

Unfortunately I'm not at my workstation for at least 3 days. If it is not a big hassle to you I'd kindly ask you (@d-a-v) to add the line this time.

I just added the missing line to patch-4 and made a new PR. Lets see if the CI build succeeds now....

@everslick
Copy link
Contributor Author

Looks good! :-)

@d-a-v d-a-v merged commit e64cb61 into esp8266:master Mar 22, 2020
@d-a-v d-a-v mentioned this pull request Mar 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

GPIOs get re-init during software restarts
2 participants
@everslick @d-a-v