-
Notifications
You must be signed in to change notification settings - Fork 13.3k
WiFiSTA - allow using DHCP again after disconnecting static IP #9020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://github.com/esp8266/Arduino/blob/1c624dd/doc/esp8266wifi/station-class.rst#config
In our docs this is mentioned right at the end. Might be more discover-able if moved to the top? Plus, what updated disconnect() behaviour from this PR. |
@mcspr I try to find the common Arduino WiFi API so there are as few differences as possible between various WiFi libraries. But |
I only thought about docs... But, considering some examples, that definitely breaks something like this? Where user would expect config() to persist and does not to always pair config() and begin(). Not sure how other cores and libs behave here
For config, might be another method?
|
I am too tired now, but I will revert this tomorrow. In esp32 too. config(0) gives more control to the user of the library. I will try to steer other libraries to config(0), if they don't support it already. |
esp8266#9020)" This reverts commit 0c599ee.
esp8266#9020)" (esp8266#9028) This reverts commit 0c599ee.
esp8266#9020)" (esp8266#9028) This reverts commit 0c599ee.
reset
_useStaticIp
to false inWiFi.disconnect()