Skip to content

Fix uploader for python3 compat and core 2.6.x #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2019
Merged

Fix uploader for python3 compat and core 2.6.x #65

merged 1 commit into from
Nov 25, 2019

Conversation

earlephilhower
Copy link
Contributor

The core moved to python3 because python (2) is EOL on January 1, 2020.
Move the search paths and platform variables to use python3 instead.

Remove the no longer needed --end parameter to upload.py

@earlephilhower
Fix uploader for python3 compat and core 2.6.x
6408285 
The core moved to python3 because python (2) is EOL on January 1, 2020.
Move the search paths and platform variables to use python3 instead.

Remove the no longer needed --end parameter to upload.py
@earlephilhower earlephilhower mentioned this pull request Nov 19, 2019
Merged
@devyte
Copy link

devyte commented Nov 24, 2019

@me-no-dev ping
I know you're very busy these days, but this is needed for core 2.6.2 release, which is imminent.

@me-no-dev me-no-dev merged commit 25890cc into esp8266:master Nov 25, 2019
@devyte
Copy link

devyte commented Nov 25, 2019

Thanks!

@me-no-dev
Copy link
Collaborator

Yeah :D now onto fixing CI, upgrading version and release :P

@me-no-dev
Copy link
Collaborator

like that nickelback song was saying... it' been a while

@earlephilhower earlephilhower deleted the fix2.6.0 branch November 25, 2019 16:24
@earlephilhower
Copy link
Contributor Author

Argh, @me-no-dev , looks like the released ZIP doesn't work with Arduino IDE:

This is with Arduino 1.8.8:

java.lang.UnsupportedClassVersionError: com/esp8266/mkspiffs/ESP8266FS has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
	at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:348)
	at processing.app.Editor.addTools(Editor.java:870)
	at processing.app.Editor.buildToolsMenu(Editor.java:728)
	at processing.app.Editor.buildMenuBar(Editor.java:540)
	at processing.app.Editor.<init>(Editor.java:290)
	at processing.app.Base.handleOpen(Base.java:858)
	at processing.app.Base.restoreSketches(Base.java:546)
	at processing.app.Base.<init>(Base.java:481)
	at processing.app.Base.main(Base.java:151)

@earlephilhower
Copy link
Contributor Author

I think the problem stems from the -target 11. When I build w/1.8 it seems to work OK
ESP8266FS-0.5.0.zip

< javac -target 11 -cp "$pde_path:$core_path:$lib_path" \
---
> javac -target 1.8 -source 1.8 -cp "$pde_path:$core_path:$lib_path" \

Attached a build with 1.8.

@earlephilhower earlephilhower mentioned this pull request Nov 25, 2019
Closed
@me-no-dev
Copy link
Collaborator

yes that is it, but this is what is on my machine :( and travis seems to break

@Bubble007
Copy link

Hello alltogether,

I have a problem to install the Arduino plugin for uploading files to ESP8266 file system.

I get the error message: “Python was not found but can be installed from the Microsoft Store: https://go.microsoft.com/fwlink?linkID=2082640SPIFFS Upload failed!”

I have Win 10 and der Arduino Ide 1.8.12.

I installed also Python 3.

I have installed the ESP8266FS-0.5.0.zip from earlephilhower in the comment on 25 Nov 2019.

All doesn’t help. Can you help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@earlephilhower @devyte @me-no-dev @Bubble007