[logger] Fix bug causing global log level to be overwritten (#8248)

swoboda1337 · jesserockz · commit 92ad6286aa04 · 2025-02-14T14:28:41.000+13:00
diff --git a/esphome/components/logger/__init__.py b/esphome/components/logger/__init__.py
@@ -247,8 +247,8 @@ async def to_code(config):
         )
     cg.add(log.pre_setup())
 
-    for tag, level in config[CONF_LOGS].items():
-        cg.add(log.set_log_level(tag, LOG_LEVELS[level]))
+    for tag, log_level in config[CONF_LOGS].items():
+        cg.add(log.set_log_level(tag, LOG_LEVELS[log_level]))
 
     cg.add_define("USE_LOGGER")
     this_severity = LOG_LEVEL_SEVERITY.index(level)
diff --git a/esphome/components/logger/logger.cpp b/esphome/components/logger/logger.cpp
@@ -102,9 +102,6 @@ void Logger::log_vprintf_(int level, const char *tag, int line, const __FlashStr
 #endif
 
 int HOT Logger::level_for(const char *tag) {
-  // Uses std::vector<> for low memory footprint, though the vector
-  // could be sorted to minimize lookup times. This feature isn't used that
-  // much anyway so it doesn't matter too much.
   if (this->log_levels_.count(tag) != 0)
     return this->log_levels_[tag];
   return this->current_level_;

Original file line number	Diff line number	Diff line change
`@@ -247,8 +247,8 @@ async def to_code(config):`
`247`	`247`	`)`
`248`	`248`	`cg.add(log.pre_setup())`
`249`	`249`
`250`		`- for tag, level in config[CONF_LOGS].items():`
`251`		`- cg.add(log.set_log_level(tag, LOG_LEVELS[level]))`
	`250`	`+ for tag, log_level in config[CONF_LOGS].items():`
	`251`	`+ cg.add(log.set_log_level(tag, LOG_LEVELS[log_level]))`
`252`	`252`
`253`	`253`	`cg.add_define("USE_LOGGER")`
`254`	`254`	`this_severity = LOG_LEVEL_SEVERITY.index(level)`