[logger] Fix bug causing global log level to be overwritten #8248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
jesserockz
approved these changes
Feb 13, 2025
swoboda1337
commented
Feb 13, 2025
| for tag, level in config[CONF_LOGS].items(): | ||
| cg.add(log.set_log_level(tag, LOG_LEVELS[level])) | ||
| for tag, log_level in config[CONF_LOGS].items(): | ||
| cg.add(log.set_log_level(tag, LOG_LEVELS[log_level])) |
There was a problem hiding this comment.
C++ param is called log_level so it makes sense to do that here too
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8248 +/- ##
==========================================
+ Coverage 53.70% 53.80% +0.09%
==========================================
Files 50 50
Lines 9408 9858 +450
Branches 1654 1361 -293
==========================================
+ Hits 5053 5304 +251
- Misses 4056 4231 +175
- Partials 299 323 +24 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Overriding logging for individual tags accidentally overwrites the global log level:
Fix this and remove an outdated comment.
Types of changes
Related issue or feature (if applicable):
Pull request in esphome-docs with documentation (if applicable):
Test Environment
Example entry for
config.yaml:# Example config.yamlChecklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: