Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[uart] Use SOC_UART_NUM as number of uarts instead of UART_NUM_MAX #7967

Merged
merged 1 commit into from
Dec 16, 2024
Merged

[uart] Use SOC_UART_NUM as number of uarts instead of UART_NUM_MAX #7967

merged 1 commit into from
Dec 16, 2024

Conversation

jesserockz
Copy link
Member

What does this implement/fix?

Following up to #7947 but for UART in case esp-idf changes UART_NUM_MAX to an enum as well.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

  • fixes

Pull request in esphome-docs with documentation (if applicable):

  • esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@jesserockz jesserockz requested a review from a team as a code owner December 16, 2024 02:27
@probot-esphome
Copy link

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (uart) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@kbx81 kbx81 enabled auto-merge (squash) December 16, 2024 04:08
@kbx81 kbx81 merged commit 1a89aa8 into dev Dec 16, 2024
96 checks passed
@kbx81 kbx81 deleted the jesserockz-2024-577 branch December 16, 2024 05:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kbx81 kbx81 kbx81 approved these changes

Assignees
No one assigned
Labels
core integration: uart small-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesserockz @kbx81