Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[audio_adc] Add new audio_adc component #8094

Merged
merged 5 commits into from
Jan 21, 2025
Merged

[audio_adc] Add new audio_adc component #8094

merged 5 commits into from
Jan 21, 2025
+200 −101

Conversation

kbx81
Copy link
Member

@kbx81 kbx81 commented Jan 16, 2025 •
edited
Loading

What does this implement/fix?

SSIA -- as we seem to be accumulating more audio components, this will make it easier to interface with them.

Note: the ES8311 component will also need to be updated, but I think that's best done in a separate PR so as to keep this one from becoming any bigger.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

  • fixes

Pull request in esphome-docs with documentation (if applicable):

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml
audio_adc:
  - platform: es7210

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@kbx81 kbx81 requested review from kahrendt and jesserockz January 16, 2025 07:01
@probot-esphome
Copy link

Hey there @kahrendt, mind taking a look at this pull request as it has been labeled with an integration (es7210) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

Hey there @kbx81,
Thanks for submitting this pull request! Can you add yourself as a codeowner for this integration? This way we can notify you if a bug report for this integration is reported.
In __init__.py of the integration, please add:

CODEOWNERS = ["@kbx81"]

And run script/build_codeowners.py

(message by NeedsCodeownersLabel)

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.86%. Comparing base (4d8b5ed) to head (37885c3).
Report is 1910 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #8094      +/-   ##
==========================================
+ Coverage   53.70%   53.86%   +0.15%     
==========================================
  Files          50       50              
  Lines        9408     9838     +430     
  Branches     1654     1358     -296     
==========================================
+ Hits         5053     5299     +246     
- Misses       4056     4212     +156     
- Partials      299      327      +28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kbx81 kbx81 force-pushed the 20250115-add-audio-adc branch from bbbfd7c to 6286027 Compare January 16, 2025 07:08
This was referenced Jan 16, 2025
Merged
Merged
@kbx81 kbx81 force-pushed the 20250115-add-audio-adc branch from 6b683b0 to 37885c3 Compare January 17, 2025 06:29
@kbx81 kbx81 added this to the 2025.2.0b1 milestone Jan 20, 2025
@jesserockz jesserockz merged commit 576dbd6 into esphome:dev Jan 21, 2025
26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jesserockz jesserockz jesserockz approved these changes

@kahrendt kahrendt Awaiting requested review from kahrendt

Assignees

@kahrendt kahrendt

Labels
has-tests integration: es7210 new-integration
Projects
None yet
Milestone
2025.2.0b1
Development

Successfully merging this pull request may close these issues.
4 participants
@kbx81 @codecov-commenter @jesserockz @kahrendt