-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdl] Implement binary sensors from keystrokes #8207
Conversation
Hey there @clydebarrow, mind taking a look at this pull request as it has been labeled with an integration ( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8207 +/- ##
==========================================
+ Coverage 53.70% 53.81% +0.10%
==========================================
Files 50 50
Lines 9408 9856 +448
Branches 1654 1360 -294
==========================================
+ Hits 5053 5304 +251
- Misses 4056 4230 +174
- Partials 299 322 +23 ☔ View full report in Codecov by Sentry. |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
What does this implement/fix?
Add an SDL platform to binary sensor to enable generic keyboard inputs. Without this, encoder and keypad based GUIs are difficult to evaluate on the host platform.
Types of changes
Related issue or feature (if applicable):
Pull request in esphome-docs with documentation (if applicable):
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: