Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdl] Implement binary sensors from keystrokes #8207

Merged
merged 7 commits into from
Feb 5, 2025

Conversation

bdm310
Copy link
Contributor

@bdm310 bdm310 commented Feb 5, 2025

What does this implement/fix?

Add an SDL platform to binary sensor to enable generic keyboard inputs. Without this, encoder and keypad based GUIs are difficult to evaluate on the host platform.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

Pull request in esphome-docs with documentation (if applicable):

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx
  • host

Example entry for config.yaml:

esphome:
  name: sdl

host:

logger:

display:
  - platform: sdl
    dimensions:
      width: 320
      height: 320
    auto_clear_enabled: false 

binary_sensor:
  - platform: sdl
    id: key_up
    key: SDLK_a
  - platform: sdl
    id: key_down
    key: SDLK_d
  - platform: sdl
    id: key_enter
    key: SDLK_s

lvgl:
  encoders:
    enter_button: key_enter
    sensor:
      left_button: key_up
      right_button: key_down

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

probot-esphome bot commented Feb 5, 2025

Hey there @clydebarrow, mind taking a look at this pull request as it has been labeled with an integration (sdl) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.81%. Comparing base (4d8b5ed) to head (51475fd).
Report is 1982 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8207      +/-   ##
==========================================
+ Coverage   53.70%   53.81%   +0.10%     
==========================================
  Files          50       50              
  Lines        9408     9856     +448     
  Branches     1654     1360     -294     
==========================================
+ Hits         5053     5304     +251     
- Misses       4056     4230     +174     
- Partials      299      322      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clydebarrow clydebarrow changed the title Sdl binary sensor [sdl] Implement binary sensors from keystrokes Feb 5, 2025
@esphome esphome bot marked this pull request as draft February 5, 2025 05:38
@esphome
Copy link

esphome bot commented Feb 5, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@clydebarrow clydebarrow marked this pull request as ready for review February 5, 2025 10:53
@esphome esphome bot requested a review from clydebarrow February 5, 2025 10:53
@clydebarrow clydebarrow merged commit e337bd7 into esphome:dev Feb 5, 2025
25 checks passed
@bdm310 bdm310 deleted the sdl-binary-sensor branch February 6, 2025 06:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants