Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to customise the order of the activities panel #3207

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rabiibrahimi
Copy link
Contributor

Currently the activities are ordered by dateStart and ordered in descending mode.
However if someone wants to change that it won't work even if they use a custom activities view and provide an orderBy and order properties. This fix the issues and allow the user to have that flexibility so they could customise how the records are ordered on the activities panels.

@yurikuzn
Copy link
Contributor

I'll look later. I'm not quite sure that there's are no nuances that should be handled. For example, passing non-existent column not producing an appropriate exception.

@rabiibrahimi
Copy link
Contributor Author

For example, passing non-existent column not producing an appropriate exception.

True if modifiedAt passed it produce an error.

Leave it with you when you have time :)

Thanks

@rabiibrahimi rabiibrahimi reopened this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants