Skip to content

fix(release): Replace all assets with chinese mirrors #11323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(release): Replace all assets with chinese mirrors #11323

wants to merge 1 commit into from

Conversation

lucasssvaz
Copy link
Collaborator

@lucasssvaz lucasssvaz commented Apr 29, 2025 •
edited
Loading

Description of Change

This pull request makes updates to the .github/scripts/on-release.sh script to improve consistency in URL handling and correct an issue in the upload logic for Chinese-specific pages. These changes ensure proper substitution of URLs and accurate references during the upload process.

Keeping it as draft until assets like this are available:
https://dl.espressif.cn/github_assets/earlephilhower/esp-quick-toolchain/releases/download/3.0.0-gnu12/aarch64-linux-gnu.mklittlefs-c41e51a.200706.tar.gz

URL handling improvements:

  • Updated the sed command to simplify and generalize the substitution of github.com URLs with dl.espressif.cn/github_assets by removing the hardcoded espressif path segment. This change applies to both development and release package JSON files. (.github/scripts/on-release.shL345-R350)

Upload logic corrections:

  • Fixed the git_safe_upload_to_pages calls for Chinese-specific pages ($PACKAGE_JSON_DEV_CN and $PACKAGE_JSON_REL_CN) to use the correct file references, ensuring that the appropriate content is uploaded. (.github/scripts/on-release.shL459-R466)

@lucasssvaz lucasssvaz self-assigned this Apr 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 29, 2025 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 305a73a

@lucasssvaz lucasssvaz marked this pull request as ready for review April 30, 2025 16:45
@lucasssvaz lucasssvaz added the Status: Review needed Issue or PR is awaiting review label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

@P-R-O-C-H-Y P-R-O-C-H-Y Awaiting requested review from P-R-O-C-H-Y

Assignees

@lucasssvaz lucasssvaz

Labels
Status: Review needed Issue or PR is awaiting review Type: CI & Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lucasssvaz