fix for "realtime uart" in esp32-hal-uart.c #1674
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you are doing uart stuff that depends on timing, the original code will leave you in the "blind" (Serial.availabe() reads ZERO) until 112 bytes have been received.
Setting this value to 1 will cause 112 times more interrupts, but still use the buffer and not leave your code blind in regards of timing.
i'm aware that his is no real solution, ideally someone (@me-no-dev, @igrr ?) would add some code to HardwareSerial and esp32-hal-uart to expose a new method or optional parameter for serial.begin which could affect this setting.
i'm happy for my project with it and did not encounter side-issues with other projects - there's enough cpu resources left to handle the 112 times higher rx-interrupt rate...