Skip to content

Wire endTransmission() fix for issue #1725 #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2018
Merged

Wire endTransmission() fix for issue #1725 #1888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ceaeb4c
removed uint8_t Wire.endTransmission(uint8_t sendStop)
bperrybap Sep 22, 2018
c7968f7
Wire library version bump for endTransmission() update
bperrybap Sep 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/Wire/library.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name=Wire
version=1.0
version=1.0.1
author=Hristo Gochkov
maintainer=Hristo Gochkov <hristo@espressif.com>
sentence=Allows the communication between devices or sensors connected via Two Wire Interface Bus. For esp8266 boards.
Expand Down
5 changes: 0 additions & 5 deletions libraries/Wire/src/Wire.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,11 +308,6 @@ uint8_t TwoWire::endTransmission(void)
return endTransmission(true);
}

uint8_t TwoWire::endTransmission(uint8_t sendStop)
{
return endTransmission(static_cast<bool>(sendStop));
}

/* stickbreaker Nov2017 better error reporting
*/
uint8_t TwoWire::lastError()
Expand Down
1 change: 0 additions & 1 deletion libraries/Wire/src/Wire.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ class TwoWire: public Stream
void beginTransmission(int address);

uint8_t endTransmission(bool sendStop);
uint8_t endTransmission(uint8_t sendStop);
uint8_t endTransmission(void);

uint8_t requestFrom(uint16_t address, uint8_t size, bool sendStop);
Expand Down