Improve _uploadReadByte #2655
Closed
Improve _uploadReadByte #2655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to test this tomorrow by just trying to do OTA updates and see if the WebServer OTA still fails occasionally. Earlier today, though, I tried a more rushed implementation of this that certainly overcame an apparent problem, as described in the source code comments associated with this PR. |
|
if we'd rather see a timeout based limitation rather than an retry limitation I could certainly implement such a thing easily enough, but in that case what should be used for the timeout duration? A hard-coded time period (10 seconds?)? HTTP_MAX_POST_WAIT (5 seconds)? |
|
We do not need this PR anymore :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change, without really understanding why, makes WebServer OTA less likely to fail with a broken pipe, and has been empirically demonstrated to recover from a condition that would otherwise prematurely terminate the connection during file transfer.