Skip to content

Base64::encode : const correctness / String by reference passing #3314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2019
Merged

Base64::encode : const correctness / String by reference passing #3314

merged 2 commits into from
Oct 2, 2019

Conversation

dirkmueller
Copy link
Contributor

Avoid passing String by-value, which is slightly less efficient
as it involves a full copy-constructor/tempstring creation.

dirkmueller and others added 2 commits October 2, 2019 08:13
@dirkmueller
Base64::encode : const correctness / String by reference passing
0ca45fe 
Avoid passing String by-value, which is slightly less efficient
as it involves a full copy-constructor/tempstring creation.
@me-no-dev
Merge branch 'master' into master
7900d37
@me-no-dev me-no-dev merged commit 6f70e27 into espressif:master Oct 2, 2019
@me-no-dev
Copy link
Member

Thanks :) totally agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirkmueller @me-no-dev