Fix commit d8b2098 (PR #3377) which includes esp_adc_cal #3648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cal component but does not update CMakeLists.txt
|
I am using arduino-esp32 as a component in an IDF project..I'm not sure if Arduino or PlatformIO supports CMake, yet, however having CI would be great to catch issues using other (future default) build environments. |
|
as soon as we move to 4.x and we can use Cmake to build the Arduino libs, the CI will do that. We have even now a check that makes sure that all files are listed in cmake, but we can not test against the libs without cmake to begin with :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix recent commit d8b2098 (PR #3377) which includes
esp_adc_calcomponent but does not updateCMakeLists.txt.