Arduino component build process fixed #5650
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
What is different to #5599 ? |
didn't see that PR. actually it does the same thing, but why it's still not applied? And also i've added IPAddress fix, there was variable name conflict with define macros |
By removing that variable you are potentially breaking any projects which depend on it's existence. It is only a name conflict in some circumstances otherwise it would have been changed long ago, usually this would only be seen if you are doing raw socket manipulation in the same file where this is included. |
|
#5599 is merged. You can not "fix" IPAddress like this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Impact
This PR will allow other users to easily compile their ESP-IDF projects with arduino as a component