Skip to content

Fix gen_insights_package.py missing on release #7650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 6, 2023
Merged

Fix gen_insights_package.py missing on release #7650

merged 4 commits into from
Jan 6, 2023

Conversation

me-no-dev
Copy link
Member

Fixes: #7649

@me-no-dev me-no-dev added this to the 2.0.7 milestone Jan 3, 2023
@me-no-dev me-no-dev self-assigned this Jan 3, 2023
SuGlider
SuGlider requested changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing Compiling Example from ESP Insights --> MinimalDiagnostics.ino + Arduino Core 2.0.6
Issue #7649 confirmed using IDE 1.8.15 :: got error message:
'C:\Users\espUser\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.6/tools/gen_insights_package.exe' is not recognized as an internal or external command, operable program, or batch file

Tried fixing it by copying /tools/gen_esp32part.exe from Arduino GitHub to
'C:\Users\espUser\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.6\tools\' folder

But it didn't work because Win11 can't execute the EXE file, terminating the compilation with this error:

This version of C:\Users\espUser\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.6\tools\gen_insights_package.exe is not compatible with the version of Windows you're running. Check your computer's system information and then contact the software publisher.

@SuGlider
Copy link
Collaborator

SuGlider commented Jan 5, 2023

@me-no-dev
Something seems wrong with the Windows EXE file gen_insights_package.exe

I see that the icon for this EXE is different from the icon for other EXE files in tools, like espota.exe and gen_esp32part.exe
I think that it may have been generated with a different process or tool (from the Python Script).

@me-no-dev
Copy link
Member Author

@sanketwadekar please have a look at the windows expecutable

@SuGlider thanks for finding this out, but it's a bit unrelated to the issue that this PR is fixing :)

@SuGlider
Copy link
Collaborator

SuGlider commented Jan 6, 2023

@me-no-dev @sanketwadekar
As requested by Sanket, I have built the file gen_insights_package.exe for Windows 10/11 compatibility.
I tested it with Arduino IDE 1.8.15 using ESP32 and the example provided. It compiled correctly.

I have pushed the new file to this branch for merging this PR.

@SuGlider SuGlider self-requested a review January 6, 2023 14:03
@me-no-dev
Copy link
Member Author

Also just added one of the Insights example to be compiled by CI under mac and windows

@me-no-dev me-no-dev merged commit 57b27cd into master Jan 6, 2023
@me-no-dev me-no-dev deleted the bugfix/gen_insights_package branch January 6, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuGlider SuGlider SuGlider approved these changes

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees

@me-no-dev me-no-dev

Labels
None yet
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.7
Development

Successfully merging this pull request may close these issues.

gen_insights_package.py. -> [Errno 2] No such file or directory
3 participants
@me-no-dev @SuGlider @P-R-O-C-H-Y