Nano ESP32: add debug support #8567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pillo79 after merging the previous two, a merge conflict appeared :) please fix |
"touch" would create the file if not present, but not delete its contents if a previous run left the file in the build dir.
"debug.toolchain.prefix" must end with a dash, since only the tool name is appended to this string. The reason this is not a major issue is that the "debug_custom.json" file (copied in the sketch directory when debugging is enabled) forces its own prefix. And to make things more interesting, the "toolchainPrefix" entry in that file should _not_ end with a dash.
1feca59 to
6113158
Compare
|
@me-no-dev Squash merge made Git do horrible things with "nested" PRs. 😖 |
me-no-dev
pushed a commit
that referenced
this pull request
Sep 4, 2023
* Nano ESP32: fix previous merge issues * platform: remove previous build options if file is missing "touch" would create the file if not present, but not delete its contents if a previous run left the file in the build dir. * platform: make debug_custom.json file customizable by board * platform: fix default debug prefix "debug.toolchain.prefix" must end with a dash, since only the tool name is appended to this string. The reason this is not a major issue is that the "debug_custom.json" file (copied in the sketch directory when debugging is enabled) forces its own prefix. And to make things more interesting, the "toolchainPrefix" entry in that file should _not_ end with a dash. * Nano ESP32: add debugging support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This adds debugging capability to the Arduino Nano ESP32 board, by allowing the user to use the Hardware CDC USB peripheral.
build_opt.hfile.platform.txt(even though it is overwritten bydebug_custom.json)Tests scenarios
Tested with an Arduino Nano ESP32 on Mac, Windows and Linux with a recent Arduino IDE (nightly builds).
Related links
Includes commits from #8565 and #8566 to avoid conflicts on
boards.txt.