Skip to content

Fix Heltec boards build.board to be uppercase #8958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 5, 2023
Merged

Fix Heltec boards build.board to be uppercase #8958

merged 8 commits into from
Dec 5, 2023

Conversation

P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y commented Dec 5, 2023 •
edited
Loading

Description of Change

Reverted part of the changes from #4577, where build.board was set to lowercase.

Pinging @Heltec-Aaron-Lee as the author of the partially reverted PR.

Tests scenarios

Related links

Related #7942
Closes #7943

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Dec 5, 2023
@VojtechBartoska VojtechBartoska added the Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. label Dec 5, 2023
@VojtechBartoska VojtechBartoska added this to the 3.0.0-Aplha3 milestone Dec 5, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Dec 5, 2023
@me-no-dev me-no-dev merged commit 609a947 into espressif:master Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.
Projects
None yet
Milestone
3.0.0-Aplha3
Development

Successfully merging this pull request may close these issues.

2.0.7 broke Arduino board compatibility by changing build.board names to lower case
3 participants
@P-R-O-C-H-Y @me-no-dev @VojtechBartoska