Skip to content

feat(uart): backports UART pin attachment from 3.0.0 to 2.0.15 #9176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 11, 2024
Merged

feat(uart): backports UART pin attachment from 3.0.0 to 2.0.15 #9176

merged 8 commits into from
Mar 11, 2024

Conversation

SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Jan 26, 2024 •
edited
Loading

Description of Change

Backports all changes made in Arduino Core 3.0.0 to 2.0.15

Backported:

Tests scenarios

Tested with ESP32-S3, ESP32-S2 and ESP32-C3

Tested using the Serial_All_CPU_Freqs.ino Example and all the backported PRs examples.

Tested with the UART CI Sketch (output example from the S2)

ESP-ROM:esp32s2-rc4-20191025
Build:Oct 25 2019
rst:0x1 (POWERON),boot:0x8 (SPI_FAST_FLASH_BOOT)
SPIWP:0xee
mode:DIO, clock div:1
load:0x3ffe6100,len:0x55c
load:0x4004c000,len:0xa70
load:0x40050000,len:0x29d8
entry 0x4004c18c
Begin when running test successful
C:\Users\espuser\Documents\Arduino\CI_HardwareSerial_test\CI_HardwareSerial_test.ino:581:begin_when_running_test:PASS
Basic transmission test successful
C:\Users\espuser\Documents\Arduino\CI_HardwareSerial_test\CI_HardwareSerial_test.ino:582:basic_transmission_test:PASS
Buffer resize test successful
C:\Users\espuser\Documents\Arduino\CI_HardwareSerial_test\CI_HardwareSerial_test.ino:583:resize_buffers_test:PASS
Change baudrate test successful
C:\Users\espuser\Documents\Arduino\CI_HardwareSerial_test\CI_HardwareSerial_test.ino:584:change_baudrate_test:PASS
Change CPU frequency test successful
C:\Users\espuser\Documents\Arduino\CI_HardwareSerial_test\CI_HardwareSerial_test.ino:585:change_cpu_frequency_test:PASS
Disabled UART calls test successful
C:\Users\espuser\Documents\Arduino\CI_HardwareSerial_test\CI_HardwareSerial_test.ino:586:disabled_uart_calls_test:PASS
Enabled UART calls test successful
C:\Users\espuser\Documents\Arduino\CI_HardwareSerial_test\CI_HardwareSerial_test.ino:587:enabled_uart_calls_test:PASS
Hello from Serial1 to detect baudrate
Auto baudrate test successful
C:\Users\espuser\Documents\Arduino\CI_HardwareSerial_test\CI_HardwareSerial_test.ino:589:auto_baudrate_test:PASS
Peripheral manager test successful
C:\Users\espuser\Documents\Arduino\CI_HardwareSerial_test\CI_HardwareSerial_test.ino:591:periman_test:PASS
Change pins test successful
C:\Users\espuser\Documents\Arduino\CI_HardwareSerial_test\CI_HardwareSerial_test.ino:592:change_pins_test:PASS
End when stopped test successful
C:\Users\espuser\Documents\Arduino\CI_HardwareSerial_test\CI_HardwareSerial_test.ino:593:end_when_stopped_test:PASS

-----------------------
11 Tests 0 Failures 0 Ignored 
OK

Related links

None.

@SuGlider SuGlider self-assigned this Jan 26, 2024
@SuGlider SuGlider marked this pull request as draft January 26, 2024 15:51
@VojtechBartoska VojtechBartoska added the Status: In Progress ⚠️ Issue is in progress label Jan 30, 2024
@VojtechBartoska VojtechBartoska added this to the 2.0.15 milestone Jan 30, 2024
SuGlider
SuGlider commented Mar 7, 2024
View reviewed changes
SuGlider
SuGlider commented Mar 7, 2024
View reviewed changes
SuGlider
SuGlider commented Mar 7, 2024
View reviewed changes
SuGlider
SuGlider commented Mar 7, 2024
View reviewed changes
SuGlider
SuGlider commented Mar 7, 2024
View reviewed changes
SuGlider
SuGlider commented Mar 7, 2024
View reviewed changes
SuGlider
SuGlider commented Mar 7, 2024
View reviewed changes
SuGlider
SuGlider commented Mar 7, 2024
View reviewed changes
SuGlider
SuGlider commented Mar 7, 2024
View reviewed changes
SuGlider
SuGlider commented Mar 7, 2024
View reviewed changes
@SuGlider SuGlider added Peripheral: UART Related to the UART peripheral or its functionality. and removed Status: In Progress ⚠️ Issue is in progress labels Mar 8, 2024
@SuGlider SuGlider marked this pull request as ready for review March 8, 2024 01:42
@SuGlider SuGlider mentioned this pull request Mar 8, 2024
Merged
@lucasssvaz lucasssvaz added the hil_test Run Hardware Tests label Mar 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024 •
edited
Loading

Unit Test Results

10 files  10 suites   4m 6s ⏱️
  9 tests   9 ✔️ 0 💤 0 ❌
14 runs  14 ✔️ 0 💤 0 ❌

Results for commit 0d24a48.

♻️ This comment has been updated with latest results.

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Mar 9, 2024
@me-no-dev me-no-dev merged commit 75b7f4b into espressif:release/v2.x Mar 11, 2024
@SuGlider SuGlider mentioned this pull request Mar 14, 2024
Closed
1 task
This was referenced Apr 13, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasssvaz lucasssvaz lucasssvaz approved these changes

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

Assignees

@SuGlider SuGlider

Labels
hil_test Run Hardware Tests Peripheral: UART Related to the UART peripheral or its functionality. Status: Pending Merge Pull Request is ready to be merged
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.15
Development

Successfully merging this pull request may close these issues.
5 participants
@SuGlider @lucasssvaz @P-R-O-C-H-Y @me-no-dev @VojtechBartoska