-
Notifications
You must be signed in to change notification settings - Fork 817
Add EIP-7702 Examples #4015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add EIP-7702 Examples #4015
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Hi hi, great start on this! 🤩 The examples are not yet working (this is likely partly AI generated?), so the So, examples are using e.g. |
@@ -64,5 +64,8 @@ | |||
"engines": { | |||
"node": ">=18", | |||
"npm": ">=7" | |||
}, | |||
"dependencies": { | |||
"@ethersproject/abi": "^5.8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have an Ethers dev dependency in package.json
root which you should be able to use, no need to add a dependency here + alter the package-lock.json
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@@ -57,9 +57,9 @@ See PR [#3524](https://github.com/ethereumjs/ethereumjs-monorepo/pull/3524): | |||
See PR [#3544](https://github.com/ethereumjs/ethereumjs-monorepo/pull/3544): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting here, since I can't do above: accicental removal (+ committed) of the packages/ethereum-tests
directory.
I think it might generally be wise to just pick the relevant changes from this PR (by just copying over) and submit a new PR, best from a branch on your side (git checkout -b new-eip-7702-examples
) and not from master
, otherwise things will likely get too messy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok ill do it
Hi @avdheshcharjan! |
This PR adds example files for the EIP-7702 implementation, demonstrating how to create and enable EIP-7702 transactions in various scenarios. It includes basic enabling, ERC20 atomic operations, and a Uniswap integration example.