Skip to content

Conversation

nnnnicholas
Copy link

@nnnnicholas nnnnicholas commented Jun 27, 2021

Proposing an update to the Getting Started docs' Metamask section to include window.ethereum.enable() as mentioned by @ricmoo here.

@nnnnicholas nnnnicholas marked this pull request as ready for review June 27, 2021 00:19
@zemse
Copy link
Collaborator

zemse commented Jun 27, 2021

Just to mention ethereum.enable is marked as deprecated in the metamask docs (and might be removed in future metamask versions). This is what they suggest instead:

ethereum.request({ method: 'eth_requestAccounts' })

@ricmoo ricmoo added documentation Documentation related issue. on-deck This Enhancement or Bug is currently being worked on. labels Aug 9, 2021
@nnnnicholas
Copy link
Author

Would be cool to see the Getting Started page updated with this info.

@nnnnicholas
Copy link
Author

nnnnicholas commented Oct 25, 2021

Actually I need to reopen this. AFAIK the Getting Started documentation instructions for "the easy solution" to connect to Metamask does not work as written. Can someone please help fix it if my proposal above is outdated?

If I understand correctly, @zemse's comment could have been more fully written out as the following?

window.ethereum.request({ method: 'eth_requestAccounts' })

While this looks like it is the correct approach, it is not intuitive to newer web3 devs as the Metamask documentation of the above function makes no mention of needing to be called to spawn the Connect Wallet dialog.

@nnnnicholas nnnnicholas reopened this Oct 25, 2021
@ricmoo ricmoo removed the on-deck This Enhancement or Bug is currently being worked on. label Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants