Fix reading source file multiple times (getsentry#2569)

pushplay · web-flow · commit 0dd89627ea54 · 2020-05-11T14:14:26.000+02:00
* Deduplicate filenames passed to addPrePostContext.

* Fix build.
diff --git a/packages/node/src/parsers.ts b/packages/node/src/parsers.ts
@@ -163,7 +163,7 @@ export function parseStack(stack: stacktrace.StackFrame[], options?: NodeOptions
     if (parsedFrame.filename) {
       parsedFrame.module = getModule(parsedFrame.filename);
 
-      if (!isInternal && linesOfContext > 0) {
+      if (!isInternal && linesOfContext > 0 && filesToRead.indexOf(parsedFrame.filename) === -1) {
         filesToRead.push(parsedFrame.filename);
       }
     }
diff --git a/packages/node/test/parsers.test.ts b/packages/node/test/parsers.test.ts
@@ -71,6 +71,42 @@ describe('parsers.ts', () => {
     });
   });
 
+  test('parseStack with duplicate files', async () => {
+    expect.assertions(1);
+    const framesWithDuplicateFiles: stacktrace.StackFrame[] = [
+      {
+        columnNumber: 1,
+        fileName: '/var/task/index.js',
+        functionName: 'module.exports../src/index.ts.fxn1',
+        lineNumber: 1,
+        methodName: 'fxn1',
+        native: false,
+        typeName: 'module.exports../src/index.ts',
+      },
+      {
+        columnNumber: 2,
+        fileName: '/var/task/index.js',
+        functionName: 'module.exports../src/index.ts.fxn2',
+        lineNumber: 2,
+        methodName: 'fxn2',
+        native: false,
+        typeName: 'module.exports../src/index.ts',
+      },
+      {
+        columnNumber: 3,
+        fileName: '/var/task/index.js',
+        functionName: 'module.exports../src/index.ts.fxn3',
+        lineNumber: 3,
+        methodName: 'fxn3',
+        native: false,
+        typeName: 'module.exports../src/index.ts',
+      },
+    ];
+    return Parsers.parseStack(framesWithDuplicateFiles).then(_ => {
+      expect(spy).toHaveBeenCalledTimes(1);
+    });
+  });
+
   test('parseStack with no context', async () => {
     expect.assertions(1);
     return Parsers.parseStack(frames, { frameContextLines: 0 }).then(_ => {

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ export function parseStack(stack: stacktrace.StackFrame[], options?: NodeOptions`
`163`	`163`	`if (parsedFrame.filename) {`
`164`	`164`	`parsedFrame.module = getModule(parsedFrame.filename);`
`165`	`165`
`166`		`- if (!isInternal && linesOfContext > 0) {`
	`166`	`+ if (!isInternal && linesOfContext > 0 && filesToRead.indexOf(parsedFrame.filename) === -1) {`
`167`	`167`	`filesToRead.push(parsedFrame.filename);`
`168`	`168`	`}`
`169`	`169`	`}`