Hi @illia-v ,

Thanks a lot for the PR and provided link.

As of the PR, could I please ask you to change the destination branch to develop?

Also, if I’m not wrong the same code sample is used on docs index page, on readme, and also there’s example code somewhere in the “/examples/“ folder. It would be nice to make the typing updates there as well. Please, let me know if it’s something you could help with.

Speaking about the thoughts on correlation of coupling and cohesion, I’m good to change the wording to the softer form, but generally I would say that it’s a separate discussion. For instance, when I think about God Object, I imagine a class with 30-50 methods calling each other in chaotic order and I cannot imagine if there’s room to call it highly cohesive & highly coupled structure — for me it looks just like an example of high coupling.

Same about destructive cohesion, I totally agree about the term, reasoning, consequences and everything else, but I’m not sure if it’s any special type of correlation. I would say that it’s just an extreme level of cohesion, where extremely low level of coupling actually creates a problem.

PS: I’m happy to have a discussion about that, but probably would stop here for now :)

As of the PR, could I please ask you to change the destination branch to develop?

Sure, done.

Also, if I’m not wrong the same code sample is used on docs index page, on readme, and also there’s example code somewhere in the “/examples/“ folder. It would be nice to make the typing updates there as well. Please, let me know if it’s something you could help with.

Done.

Speaking about the thoughts on correlation of coupling and cohesion, I’m good to change the wording to the softer form, but generally I would say that it’s a separate discussion. For instance, when I think about God Object, I imagine a class with 30-50 methods calling each other in chaotic order and I cannot imagine if there’s room to call it highly cohesive & highly coupled structure — for me it looks just like an example of high coupling.

Same about destructive cohesion, I totally agree about the term, reasoning, consequences and everything else, but I’m not sure if it’s any special type of correlation. I would say that it’s just an extreme level of cohesion, where extremely low level of coupling actually creates a problem.

PS: I’m happy to have a discussion about that, but probably would stop here for now :)

There was a discussion in comments of the article about God object. It looks unfinished, unfortunately.

The article author defines "the number of connections inside a code component (cohesion) and between code components (coupling)." If this definition is used, a God object does seem to have high cohesion, and destructive decoupling does seem to result in low cohesion.

BTW, there is an article from his opponent, he provides some other examples of low cohesion + loose coupling and high cohesion + tight coupling.

Speaking for myself, I am still defining cohesion and coupling 🙂. They are pretty subjective.

@illia-v many thanks for the changes, merged. Also, thanks a lot for some education about cohesion and coupling, super helpful to look at things from various perspectives :) I'll definitely mention this PR when speak about coupling and cohesion next time.