Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ANSITextWrapper._handle_long_word #3573

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hhsiao
Copy link
Contributor

@hhsiao hhsiao commented Jun 30, 2024

Added ANSITextWrapper._handle_long_word to handle wrapping for east_asian_word.

Brief overview of PR changes/additions

Motivation for adding to Evennia

Other info (issues closed, discussion etc)

Added ANSITextWrapper._handle_long_word to handle wrapping for east_asian_word.
@hhsiao hhsiao mentioned this pull request Jul 6, 2024
Copy link
Member

@Griatch Griatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a private method that is not used anywhere... It can't be merged like this without a much better documentation and use case presented. I would also suggest adding a unit test.

Comment on lines +202 to +209
def _handle_long_word(self, reversed_chunks, cur_line, cur_len, width):
"""_handle_long_word(chunks : [string],
cur_line : [string],
cur_len : int, width : int)

Handle a chunk of text (most likely a word, not whitespace) that
is too long to fit in any line.
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Google doc style. See Evennia's style guide and all other methods in this module.

@Griatch
Copy link
Member

Griatch commented Aug 11, 2024

Ping.

@Griatch
Copy link
Member

Griatch commented Feb 15, 2025

Ping. This requires tests and better documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants