22 Updated numpy dependecy as quickfix #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomuben
reviewed
Feb 11, 2022
.github/workflows/pytest.yaml
Outdated
Comment on lines
20
to
25
| - name: apt update | ||
| run: sudo apt-get update | ||
| - name: Install blas for Numpy from source | ||
| run: sudo apt-get install -y libblas-dev #highly recommended for numpy from source, check https://numpy.org/devdocs/user/building.html#prerequisites | ||
| - name: Install lapack for Numpy from source | ||
| run: sudo apt-get install -y liblapack-dev #highly recommended for numpy from source, check https://numpy.org/devdocs/user/building.html#prerequisites |
There was a problem hiding this comment.
You can do that in one single step:
Suggested change
| - name: apt update | |
| run: sudo apt-get update | |
| - name: Install blas for Numpy from source | |
| run: sudo apt-get install -y libblas-dev #highly recommended for numpy from source, check https://numpy.org/devdocs/user/building.html#prerequisites | |
| - name: Install lapack for Numpy from source | |
| run: sudo apt-get install -y liblapack-dev #highly recommended for numpy from source, check https://numpy.org/devdocs/user/building.html#prerequisites | |
| - name: Install lapack/blas for Numpy from source | |
| run: sudo apt-get update && sudo apt-get install -y liblapack-dev libblas-dev #highly recommended for numpy from source, check https://numpy.org/devdocs/user/building.html#prerequisites |
There was a problem hiding this comment.
right. done
tomuben
reviewed
Feb 11, 2022
|
I noticed that too. I don't know if there is a reason for that. |
tomuben
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #22
We decided against updating to python 3.8 right now, and build Numpy from source without the Buffer overflow issue instead.
The update to python 3.8 with the newest Numpy/Pandas will be moved to a new issue.