fix: add check for empty target on worksheet-xform reconcile

kyleamazza-fq · kyleamazza-fq · commit 040604a318ad · 2024-11-27T11:19:55.000-08:00
diff --git a/lib/xlsx/xform/sheet/worksheet-xform.js b/lib/xlsx/xform/sheet/worksheet-xform.js
@@ -458,7 +458,7 @@ class WorkSheetXform extends BaseXform {
     // options.merges.reconcile(model.mergeCells, model.rows);
     const rels = (model.relationships || []).reduce((h, rel) => {
       h[rel.Id] = rel;
-      if (rel.Type === RelType.Comments) {
+      if (rel.Type === RelType.Comments && options.comments[rel.Target]) {
         model.comments = options.comments[rel.Target].comments;
       }
       if (rel.Type === RelType.VmlDrawing && model.comments && model.comments.length) {

Original file line number	Diff line number	Diff line change
`@@ -458,7 +458,7 @@ class WorkSheetXform extends BaseXform {`
`458`	`458`	`// options.merges.reconcile(model.mergeCells, model.rows);`
`459`	`459`	`const rels = (model.relationships \|\| []).reduce((h, rel) => {`
`460`	`460`	`h[rel.Id] = rel;`
`461`		`- if (rel.Type === RelType.Comments) {`
	`461`	`+ if (rel.Type === RelType.Comments && options.comments[rel.Target]) {`
`462`	`462`	`model.comments = options.comments[rel.Target].comments;`
`463`	`463`	`}`
`464`	`464`	`if (rel.Type === RelType.VmlDrawing && model.comments && model.comments.length) {`