fix: table column style bug and addTable colum type (#2649)

jbuck-lineleap · web-flow · commit 5bed18b45e82 · 2024-01-12T14:48:37.000+01:00
* fix table column style bug and addTable colum type

* make TableColumnProperties.style optional
diff --git a/index.d.ts b/index.d.ts
@@ -1832,6 +1832,11 @@ export interface TableColumnProperties {
 	  * Optional formula for custom functions
 	  */
 	totalsRowFormula?: string;
+
+	/**
+	 * Styles applied to the column
+	 */
+	style?: Partial<Style>;
 }
 
 
diff --git a/lib/doc/table.js b/lib/doc/table.js
@@ -183,7 +183,7 @@ class Table {
     const assignStyle = (cell, style) => {
       if (style) {
         Object.keys(style).forEach(key => {
-          cell[key] = style[key];
+          cell.style[key] = style[key];
         });
       }
     };
diff --git a/test/test-table.js b/test/test-table.js
@@ -1,4 +1,4 @@
-const Excel = require('../lib/exceljs.nodejs.js');
+const Excel = require('../lib/exceljs.nodejs');
 const HrStopwatch = require('./utils/hr-stopwatch');
 
 const [, , filename] = process.argv;
@@ -47,14 +47,18 @@ ws.addTable({
       totalsRowFunction: 'max',
       filterButton: true,
       totalsRowResult: 8,
+      style: {numFmt: '0.00%'},
     },
     {
       name: 'Word',
       filterButton: false,
       style: {font: {bold: true, name: 'Comic Sans MS'}},
     },
   ],
-  rows: words.map((word, i) => [new Date(+today + (86400 * i)), i, word]),
+  rows: words.map((word, i) => {
+    const additionalDays = 86400 * i;
+    return [new Date(today + additionalDays), i, word];
+  }),
 });
 
 const stopwatch = new HrStopwatch();

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ class Table {`
`183`	`183`	`const assignStyle = (cell, style) => {`
`184`	`184`	`if (style) {`
`185`	`185`	`Object.keys(style).forEach(key => {`
`186`		`- cell[key] = style[key];`
	`186`	`+ cell.style[key] = style[key];`
`187`	`187`	`});`
`188`	`188`	`}`
`189`	`189`	`};`