fix: table column style bug and addTable colum type #2649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siemienik
approved these changes
Jan 12, 2024
aaron-harvey
added a commit
to aaron-harvey/exceljs
that referenced
this pull request
Mar 28, 2024
fix: table column style bug and addTable colum type (exceljs#2649)
rafaelcaniello
added a commit
to FieldControl/exceljs
that referenced
this pull request
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A continuation of #1907 with an added test and updates typings to allow for styles to be set in the column definition of a table
Test plan
In a project that is using exceljs as a dependency, i took the following steps:
node_modules/exceljs/lib/doc/table.jscell[key] = style[key]=>cell.style[key] = style[key]{ name: 'Column Name', totalsRowFunction: 'sum', style: { numFmt: '0.00%' } }0.00%'Related to source code (for typings update)
https://github.com/exceljs/exceljs/blob/master/lib/doc/table.js#L183-L189