Fix problems caused by case of worksheet names #1065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Alanscut Is will still working when it will attempt to read file with two worksheets named: "name", "NAME" ? |
|
@Siemienik yes, it could. But when we create a file with two worksheets with the same names regardless of case, the file will report an error when opening it. So when we prevent creating such file, the case you mentioned will not exist. |
Siemienik
approved these changes
Jan 13, 2020
|
@Alanscut - nice choice of 31 character sheet name in the spec file :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
1.The sheet name of the excel file created in the windows system is not case sensitive. But the
workbook.addWorksheet ()method does not do the corresponding processing, This PR fixes issues caused by case of sheet names.2.fix for #1064